-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release feed without PR tags #2665
Comments
@orangemocha this is your commit tagging thing from the merge job. |
Yep, that's the internal tag. There are a couple : Hopefully we can filter them out from the atom feed. @nodejs/build |
Do we need to use tags for this? |
It could be a branch. Given that most people don't fetch tags, it is less visible as a tag but other than that I don't think it matters much. |
Actually I think this should warrant switching off tags ASAP. |
@rvagg how difficult would it be to filter the atom feed? If it's just a matter of adding a grep line to a script, that would be easier than changing the Jenkins jobs to use branches. It can certainly be done but it's not as easy as changing a string from "refs/tag" to a "refs/branch" and the tag approach has had a few months of testing. |
..but I'll look into it in more detail tomorrow. |
@orangemocha This isn't something we have control of. GitHub does it. |
@Fishrock123 : sold 😉 I'll fix it |
I ❤️ you guys for your responsiveness on something that could've been totally ignored. Much appreciated. |
The CI job isn't being used anymore, so I'm going to close this. Future ones will have to use a branch, if re-implemented. |
Thanks a lot! |
Excuse the meta question, but the release feed (https://github.com/nodejs/node/releases.atom) has been very chatty with tags from pull requests. Is there a release feed without those? I'd hate to miss security releases from our slack channel.
The text was updated successfully, but these errors were encountered: