Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release feed without PR tags #2665

Closed
nathanboktae opened this issue Sep 2, 2015 · 12 comments
Closed

Release feed without PR tags #2665

nathanboktae opened this issue Sep 2, 2015 · 12 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@nathanboktae
Copy link

Excuse the meta question, but the release feed (https://github.com/nodejs/node/releases.atom) has been very chatty with tags from pull requests. Is there a release feed without those? I'd hate to miss security releases from our slack channel.

@Fishrock123
Copy link
Contributor

@orangemocha this is your commit tagging thing from the merge job.

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Sep 2, 2015
@orangemocha
Copy link
Contributor

Yep, that's the internal tag. There are a couple : jenkins-accept-pull-request-temp2, jenkins-accept-commit-temp2

Hopefully we can filter them out from the atom feed. @nodejs/build

@Fishrock123
Copy link
Contributor

Do we need to use tags for this?

@orangemocha
Copy link
Contributor

It could be a branch. Given that most people don't fetch tags, it is less visible as a tag but other than that I don't think it matters much.

@Fishrock123
Copy link
Contributor

Actually I think this should warrant switching off tags ASAP.

@orangemocha
Copy link
Contributor

@rvagg how difficult would it be to filter the atom feed? If it's just a matter of adding a grep line to a script, that would be easier than changing the Jenkins jobs to use branches. It can certainly be done but it's not as easy as changing a string from "refs/tag" to a "refs/branch" and the tag approach has had a few months of testing.

@orangemocha
Copy link
Contributor

..but I'll look into it in more detail tomorrow.

@Fishrock123
Copy link
Contributor

@orangemocha This isn't something we have control of. GitHub does it.

@orangemocha
Copy link
Contributor

@Fishrock123 : sold 😉 I'll fix it

@nathanboktae
Copy link
Author

I ❤️ you guys for your responsiveness on something that could've been totally ignored. Much appreciated.

@Fishrock123
Copy link
Contributor

The CI job isn't being used anymore, so I'm going to close this. Future ones will have to use a branch, if re-implemented.

@nathanboktae
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

3 participants