Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI failures #28152

Closed
BridgeAR opened this issue Jun 10, 2019 · 4 comments
Closed

Windows CI failures #28152

BridgeAR opened this issue Jun 10, 2019 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@BridgeAR
Copy link
Member

BridgeAR commented Jun 10, 2019

From the last 100 CI runs only 14 succeeded on Windows. This is pretty bad and it's hard to actually get any CI run to become green.

I am not sure if this is already looked at or not but if not, we should definitely try to fix those ASAP. I just do not know much about Windows and won't be of much help.

// cc @nodejs/platform-windows @nodejs/testing


@mmarchini the percentage seems a bit off on your CI health indicator (101%):

image

EDIT(by @sam-github): issues labelled flaky on windows

@BridgeAR BridgeAR added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jun 10, 2019
@refack
Copy link
Contributor

refack commented Jun 10, 2019

FWIW I know of two issues that were prevalent that were addressed in #28035 (one hopefully solved, and one marked as known flaky).
Currently the common flakes I see most often are (for example in the daily master test):

Some more discussion at
nodejs/reliability#1
nodejs/build#1829 (comment)

Any assistance will be greatly appreciated.

@refack refack added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jun 10, 2019
@MichelLopez
Copy link

cc @joaocgreis @bzoz for tracking

@sam-github
Copy link
Contributor

For prominence, I edited in a link to the list of issues for flaky windows tests, https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22CI+%2F+flaky+test%22+label%3Awindows, there are 13 ATM.

@jasnell
Copy link
Member

jasnell commented Jun 25, 2020

Not obvious that there's anything left here actionable. Closing but can reopen if necessary

@jasnell jasnell closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

7 participants