Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to git bisect #28834

Closed
mcollina opened this issue Jul 24, 2019 · 6 comments
Closed

Unable to git bisect #28834

mcollina opened this issue Jul 24, 2019 · 6 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@mcollina
Copy link
Member

I'm trying to do a git bisect, but I'm unable to compile a commit because of a problem with snapshots:

/home/matteo/repositories/node-fork/out/Release/obj.target/v8_snapshot/geni/embedded.cc:5:10: fatal error: src/snapshot/macros.h: No such file or directory
 #include "src/snapshot/macros.h"
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:322: recipe for target '/home/matteo/repositories/node-fork/out/Release/obj.target/v8_snapshot/geni/embedded.o' failed
make[1]: *** [/home/matteo/repositories/node-fork/out/Release/obj.target/v8_snapshot/geni/embedded.o] Error 1
rm e679ee6821ea85f86c7c3db01ddab6ba3d24e9eb.intermediate cda36b0c0b2deb93a9f02e1c7afebcdb202cfbc5.intermediate cc74a04f9485c5e1c2551276ca90c06c9d5e25c4.intermediate
Makefile:99: recipe for target 'node' failed
make: *** [node] Error 2
  • Version: master, commit 25b78c0
  • Platform: Linux
  • Subsystem: snapshot
@mcollina
Copy link
Member Author

cc @joyeecheung

@addaleax
Copy link
Member

I and others have run into this in the past, I think a hard reset via git clean -fdx did the trick (but obviously costs some time).

@addaleax addaleax added the build Issues and PRs related to build files or the CI. label Jul 24, 2019
@mcollina
Copy link
Member Author

That fixes it. Should we document it somewhere?

@joyeecheung
Copy link
Member

joyeecheung commented Jul 24, 2019

Looks like a duplicate of #28675

BTW I think I ran into this month(s?) ago on V8 master, I remember a fresh clone of V8 and clearing my ccache did the trick back then, so it probably comes from the upstream.

EDIT: um, no, I think I had another issue

@mcollina
Copy link
Member Author

Yes it is. Closing and thanks for the help!

@nemanjajovanovic97
Copy link

For those who face the same issue: running git clean -fdx is not always enoguh. The full sequence of commands that need to be run in order to remove all cached build files are:

rm .gitignore
git clean -fdx
git stash
git stash drop

Then build and continue bisecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

4 participants