Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: WritableStream issues #29042

Closed
11 tasks
ronag opened this issue Aug 8, 2019 · 1 comment
Closed
11 tasks

fs: WritableStream issues #29042

ronag opened this issue Aug 8, 2019 · 1 comment

Comments

@ronag
Copy link
Member

ronag commented Aug 8, 2019 •
edited
Loading

  • error can be emitted after close
    • write after end
    • invalid argument
  • open can be emitted after error
  • does not use errorOrDestroy on close()
  • should not emit error, use errorOrDestroy or callback.
  • _write does an unnecessary check for instanceof Buffer (fs: unecessary argument validation #29043).
  • calling write before fd and closing, will cause write to happen on destroyed stream (i.e. flush after destroy)
  • don't use end() instead of destroy(). Keep track of pendingcb instead. (related issue stream: Writable should not invoke _destroy while pending ops #29044)
  • emit 'close' on destroy
  • emit 'close' close error
@ronag ronag changed the title fs: writable issues fs: WritableStream issues Aug 8, 2019
@ronag
Copy link
Member Author

ronag commented Oct 6, 2019

I'm moving this into my own list and will open PR's accordingly when my number of open PR's drop.

@ronag ronag closed this as completed Oct 6, 2019
@tniessen tniessen mentioned this issue Apr 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronag