Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect name of HTTP status code 425 #29879

Closed
hcz opened this issue Oct 7, 2019 · 1 comment
Closed

Incorrect name of HTTP status code 425 #29879

hcz opened this issue Oct 7, 2019 · 1 comment
Labels
http Issues or PRs related to the http subsystem.

Comments

@hcz
Copy link
Contributor

hcz commented Oct 7, 2019

Current icorrect: 425 (Unordered Collection) https://github.com/nodejs/node/blob/master/lib/_http_server.js#L115
Correct code: 425 (Too Early) https://tools.ietf.org/html/rfc8470#section-5.2

RFC 4918, that was mentioned in comment, does not contain status code 425.

I've found this name for this status code only in the very old and one of the first RFC 3648 drafts.

Thus, the idea of renaming this status code for the future Node.js versions seems to be good.

Related issue: #1470

  • Version: any
  • Platform: any
  • Subsystem: any
@hcz hcz mentioned this issue Oct 7, 2019
Closed
4 tasks
@addaleax addaleax added the http Issues or PRs related to the http subsystem. label Oct 7, 2019
@hcz hcz mentioned this issue Oct 7, 2019
Closed
@lpinca
Copy link
Member

lpinca commented Oct 11, 2019

Fixed by 458a38c.

@lpinca lpinca closed this as completed Oct 11, 2019
@joshuaharry joshuaharry mentioned this issue Jul 4, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@addaleax @lpinca @hcz