Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test: test-http-dump-req-when-res-ends on windows #30011

Closed
AshCripps opened this issue Oct 17, 2019 · 9 comments
Closed

flaky test: test-http-dump-req-when-res-ends on windows #30011

AshCripps opened this issue Oct 17, 2019 · 9 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform.

Comments

@AshCripps
Copy link
Member

AshCripps commented Oct 17, 2019 •
edited by sam-github
Loading

  • Version: Master
  • Platform: Windows
  • Subsystem: http

Last 3 nightly builds failed on master, this test has failed the past two builds.

Does anyone want to investigate or should we mark it as flaky?

@nodejs/platform-windows
@sam-github sam-github added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform. labels Oct 17, 2019
@sam-github
Copy link
Contributor

@nodejs/platform-windows ... because I'm not sure if @AshCripps (not yet a collab, but on my team) can ping teams.

@sam-github
Copy link
Contributor

Flaky on more than the nightlies :-(

https://ci.nodejs.org/job/node-test-binary-windows-2/3582/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=0/ from #29451

@sam-github sam-github mentioned this issue Oct 17, 2019
Closed
3 tasks
@richardlau
Copy link
Member

Maybe also cc @ronag as the test uses http and streams.

@ronag
Copy link
Member

ronag commented Oct 17, 2019

I'm not very good at reading these. Do we know where in the test if fails?

@richardlau
Copy link
Member

It looks like its timing out.

@targos
Copy link
Member

targos commented Nov 6, 2019

This test fails a lot. I have trouble to get a green Windows CI because of it.

/cc @nodejs/testing

@AshCripps AshCripps mentioned this issue Nov 6, 2019
Closed
4 tasks
@AshCripps
Copy link
Member Author

Closing as per #30316

@richardlau
Copy link
Member

Closing as per #30316

It's not actually de-flaked though, just marked flaky to prevent the builds from failing. There's still an underlying issue in either the test or code that needs to be investigated.

@richardlau richardlau reopened this Nov 19, 2019
@lpinca
Copy link
Member

lpinca commented Nov 20, 2019

Addressed by #30360.

@lpinca lpinca closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sam-github @lpinca @targos @ronag @richardlau @AshCripps