Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __dirname and __filename on ES Modules #30771

Closed
juanarbol opened this issue Dec 3, 2019 · 2 comments
Closed

Add __dirname and __filename on ES Modules #30771

juanarbol opened this issue Dec 3, 2019 · 2 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js.

Comments

@juanarbol
Copy link
Member

juanarbol commented Dec 3, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
It's a feature request.

Describe the solution you'd like
Would be nice to add __dirname, and __filename. to ES Modules, I've read the docs, but also read TC39 proposal, they don't decline using this variables.

Describe alternatives you've considered
I have no idea. By the way, I've added __filename and __dirname properties to import.meta instead of suggestion of how to get these values.
@juanarbol
Copy link
Member Author

cc: @ryzokuken

@richardlau richardlau added esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js. labels Dec 3, 2019
@devsnek
Copy link
Member

devsnek commented Dec 3, 2019

Duplicate of nodejs/modules#121

@devsnek devsnek marked this as a duplicate of nodejs/modules#121 Dec 3, 2019
@devsnek devsnek closed this as completed Dec 3, 2019
@devsnek devsnek added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richardlau @devsnek @juanarbol