-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make all experimental warning messages consistent #30803
Labels
experimental
Issues and PRs related to experimental features.
Comments
pd4d10
changed the title
make all experimental warning messages consistent
module: make all experimental warning messages consistent
Dec 5, 2019
/cc @guybedford |
We've had the If there are other inconsistencies though we should change them. |
OK, get it. Found these flags. Seems not related to module. (node:70168) ExperimentalWarning: Policies are experimental. # --experimental-policy
(node:70168) ExperimentalWarning: The --frozen-intrinsics flag is experimental # --frozen-intrinsics |
pd4d10
changed the title
module: make all experimental warning messages consistent
make all experimental warning messages consistent
Dec 5, 2019
Those both seem worth doing to me. The added benefit is ensuring that the code examples follow the correct patterns for future reference. |
(//cc @bmeck) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some experimental warning messages' contents are not consistent, for example:
(node:70168) ExperimentalWarning: The ESM module loader is experimental. (node:70372) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time
Shall we make them consistent? If so I'm willing to submit a PR to solve this.
There are two general methods to emit experimental warnings. I think we can make use of them.
JavaScript version
node/lib/internal/util.js
Lines 170 to 176 in 1549c8e
C++ version (introduced in #30617)
node/src/node_process_events.cc
Lines 102 to 112 in 1549c8e
The text was updated successfully, but these errors were encountered: