Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: SyntaxError thrown when entering bigint literal inside multi-line input #31919

Closed
mscdex opened this issue Feb 22, 2020 · 12 comments
Closed
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. repl Issues and PRs related to the REPL subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Feb 22, 2020

  • Version: v10.x
  • Platform: all
  • Subsystem: repl

What steps will reproduce the bug?

$ node
> function foo() {
... let n = 10n;
Thrown:
let n = 10n;
           ^

SyntaxError: Unexpected end of input
>

How often does it reproduce? Is there a required condition?

Reproduces all the time.

What is the expected behavior?

Should not cause an exception.

What do you see instead?

An exception.

Additional information

Works on master. Works when run from a script instead of the repl.

@mscdex mscdex added repl Issues and PRs related to the REPL subsystem. v10.x labels Feb 22, 2020
@mscdex
Copy link
Contributor Author

mscdex commented Feb 22, 2020

Looks like #27400 would need to be backported?

@BridgeAR BridgeAR added good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Mar 9, 2020
@thoqbk
Copy link
Contributor

thoqbk commented Mar 14, 2020

@mscdex can I take up this?

@upatel32
Copy link

does this still need work?

@aashutoshrathi
Copy link

aashutoshrathi commented Apr 1, 2020

Is this issue still valid?

@HassanRazaMuhammadTufail

I wanna work on this. can anyone guide me for my first time contribution?

@addaleax
Copy link
Member

Maybe @BridgeAR ?

@BridgeAR
Copy link
Member

@HassanRazaMuhammadTufail please feel free to reach out to me through my twitter account or email. I'm happy to have a short video session to help you get this backported.

@dongskyler
Copy link

dongskyler commented Apr 22, 2020

Does this issue still need input? I'm happy to get involved

@HassanRazaMuhammadTufail

@HassanRazaMuhammadTufail please feel free to reach out to me through my twitter account or email. I'm happy to have a short video session to help you get this backported.

@BridgeAR I have emailed you. kindly help me out in contributing.

@preyunk
Copy link
Contributor

preyunk commented May 27, 2020

Anyone still working on this issue?

@jaime-alex
Copy link

jaime-alex commented Jul 16, 2020

It seems that this issue has already been solved
image

@targos
Copy link
Member

targos commented Jul 16, 2020

This only affects Node.js v10.x. I'm closing the issue because v10 is now in maintenance LTS mode and will only get critical fixes.

@targos targos closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

No branches or pull requests