Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-child-process-emfile.js fails on freebsd #3193

Closed
evanlucas opened this issue Oct 5, 2015 · 7 comments
Closed

test-child-process-emfile.js fails on freebsd #3193

evanlucas opened this issue Oct 5, 2015 · 7 comments
Labels
child_process Issues and PRs related to the child_process subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@evanlucas
Copy link
Contributor

I haven't had a chance to look into specifics, but just wanted to note it.

Here is the error:

not ok 878 test-child-process-emfile.js
#
#assert.js:89
#  throw new assert.AssertionError({
#  ^
#AssertionError: 0 undefined null
#    at emitTwo (events.js:87:13)
#    at ChildProcess.emit (events.js:172:7)
#    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
@evanlucas
Copy link
Contributor Author

@rvagg
Copy link
Member

rvagg commented Oct 5, 2015

mm, I noticed this the other day, /cc @nodejs/platform-freebsd

@brendanashworth brendanashworth added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Oct 6, 2015
@Trott
Copy link
Member

Trott commented Oct 13, 2015

#3335 isn't a fix but may at least help point someone in the right direction.

@jbergstroem
Copy link
Member

Just saw it in the 32-bit environment with the updated error message:

not ok 898 test-child-process-emfile.js
#
#assert.js:89
#  throw new assert.AssertionError({
#  ^
#AssertionError: "exit" should not be emitted (the process never spawned!)
#    at ChildProcess.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd101-32/test/sequential/test-child-process-emfile.js:32:10)
#    at emitTwo (events.js:87:13)
#    at ChildProcess.emit (events.js:172:7)
#    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

@jbergstroem jbergstroem changed the title test-child-process-emfile.js fails on freebsd 64-bit test-child-process-emfile.js fails on freebsd Oct 20, 2015
@Trott
Copy link
Member

Trott commented Feb 11, 2016

On FreeBSD, I haven't noticed this test failing (or any tests, for that matter, hooray!). I suspect this was fixed by d89bc7b. Closing.

@Trott Trott closed this as completed Feb 11, 2016
@kapouer
Copy link
Contributor

kapouer commented Feb 11, 2016

For what it's worth, on debian/kfreebsd the test has not been failing either.

@jbergstroem
Copy link
Member

(same on gentoo/freebsd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

6 participants