thread-local storage unavailable on OSX10.10

[gabrielschulhof]

Steps to reproduce:

0. Log into test-macstadium-macos10.10-x64-1
1. git clone https://github.com/nodejs/node
2. cd node
3. ./configure
4. Now that there's a workaround for the configure issue, make

The result:

  c++ -o /Users/administrator/gabrielschulhof/node/out/Release/obj.target/libnod
e/src/node_binding.o ../src/node_binding.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IM
MINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHA
RED' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEP
RECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '
-DHAVE_DTRACE=1' '-DNODE_ENABLE_LARGE_CODE_PAGES=1' '-D__POSIX__' '-DNODE_USE_V8
_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPE
NSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATIO
N=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-D_LARGEFILE_SOUR
CE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/administrat
or/gabrielschulhof/node/out/Release/obj/gen -I/Users/administrator/gabrielschulh
of/node/out/Release/obj/gen/include -I/Users/administrator/gabrielschulhof/node/
out/Release/obj/gen/src -I../deps/histogram/src -I../deps/uvwasi/include -I../de
ps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common 
-I../deps/zlib -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/inc
lude -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl
/openssl/include  -O3 -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -W
endif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-lab
els -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptio
ns -fno-strict-aliasing -MMD -MF /Users/administrator/gabrielschulhof/node/out/R
elease/.deps//Users/administrator/gabrielschulhof/node/out/Release/obj.target/li
bnode/src/node_binding.o.d.raw   -c
../src/node_binding.cc:243:8: error: thread-local storage is not supported for t
he current target
static thread_local node_module* thread_local_modpending;
       ^

Building master at c160073.

[addaleax]

I guess reverting d3b10f6 might be a reasonable workaround? The real solution is probably updating xcode/clang, though…

[richardlau]

We don't build master on 10.10 though? We're about to bump the minimum deployment level to 10.13 for Node.js 14: #32454

[gabrielschulhof]

@richardlau in that case this shall soon be moot, AFAICT.