Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs.open() can keep the event loop open in some cases #34266

Closed
Trott opened this issue Jul 8, 2020 · 5 comments
Closed

fs.open() can keep the event loop open in some cases #34266

Trott opened this issue Jul 8, 2020 · 5 comments
Labels
fs Issues and PRs related to the fs subsystem / file system.

Comments

@Trott
Copy link
Member

Trott commented Jul 8, 2020

  • Version: 15.0.0-pre (master branch)
  • Platform: Raspberry Pi 2 and Raspberry Pi 3
  • Subsystem: fs

What steps will reproduce the bug?

See test-fs-open-no-close.js added to known_issues in #34228.

How often does it reproduce? Is there a required condition?

I strongly suspect the issue is that the filesystem is NFS-mounted.

What is the expected behavior?

The event loop should not be held open and the test should exit.

What do you see instead?

On the Raspberry Pi devices in CI, the test file times out because it never exits.

Additional information

@Trott
Copy link
Member Author

Trott commented Jul 8, 2020

@nodejs/fs

@ronkorving
Copy link
Contributor

ronkorving commented Jul 9, 2020

The event loop should be held open and the test should exit.

"should not be held open" I assume?

@himself65 himself65 added the fs Issues and PRs related to the fs subsystem / file system. label Jul 9, 2020
@Trott
Copy link
Member Author

Trott commented Jul 9, 2020

The event loop should be held open and the test should exit.

"should not be held open" I assume?

Yes, indeed. Fixed. Thanks!

@Trott
Copy link
Member Author

Trott commented Aug 7, 2020

@bnoordhuis Are you still interested in investigating this? (Ref: #34228 (review)) And if so, do you need help getting set up with ssh access to one of the Raspberry Pi devices or is that already sorted out?

@bcoe
Copy link
Contributor

bcoe commented Oct 13, 2020

This appears to have been addressed by #35566, I will keeping an eye on the next few builds to make sure it's not a still a flake.

@bcoe bcoe closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants