-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backporting util/types
, path/posix
and path/win32
to v15 proposal
#35788
Comments
util/types
, path/unix
and path/win32
to v15 proposalutil/types
, path/posix
and path/win32
to v15 proposal
I don't think that's true, v15 should not be considered unstable – the odd numbered release rule was in place in the early days of Node.js 0.x IIRC, nowdays Node.js follows semver for the most part. Stability should not be the focus anyway, breaking changes have been landed on even numbered releases too (E.G.: #27417 landed in v12.2.0). Correct me if I'm wrong, the PR at stake here are not introducing breaking changes, but they do add a new core module which is the reason they got labeled Here's what I could find in the docs regarding the add of a new modules in core: node/doc/guides/collaborator-guide.md Lines 328 to 346 in 7083425
Nothing here stipulates the PR MUST be considered as
|
There's still the chance someone in an enterprise app has named a private package, or manually added a dir, that conflicts with these module names - obviously it's exceedingly unlikely. If it's decided to backport them, I can ensure that |
@nodejs/tsc @nodejs/releasers @nodejs/modules-active-members |
Just in case I'm not at the TSC meeting: I'm in favor of backporting these changes to the 15.x line. |
Is there anyone against that? |
+1 from me. |
I removed the |
@targos is this a general policy change about new core modules being semver-major? Or were those two PRs included in the one-off decision about the diagnostics module? |
@ExE-Boss k, thanks I will remove from the TSC agenda instead |
Is your feature request related to a problem? Please describe.
I’d like to get #34055 and #34962 backported to v15.x.
Note that no backport PRs exist yet, and the above PRs were only merged into v16.0.
Describe the solution you'd like
I propose the following options:
Backport util: add
util/types
alias module #34055 and path: addpath/posix
andpath/win32
alias modules #34962 as‑is to v15, which, as an odd numbered release, is considered an unstable non‑LTS release, and thus some minor breakage might be somewhat acceptable for it.Backport util: add
util/types
alias module #34055 and path: addpath/posix
andpath/win32
alias modules #34962 to v15, but restrict them to thenode:
scheme until v16, with the following sub‑options:Add support for
require("node:<built‑in‑id>")
and thusrequire("node:util/types")
,require("node:path/posix")
andrequire("node:path/win32")
. (see also: Add support fornode:
‑prefixed imports of built‑in modules torequire(…)
#36098)Don’t add support for
require("node:<built‑in‑id>")
, thus only supportingimport("node:util/types")
,import("node:path/posix")
andimport("node:path/win32")
, but notrequire("node:util/types")
,require("node:path/posix")
andrequire("node:path/win32")
The text was updated successfully, but these errors were encountered: