-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importModuleDynamically for vm module is cached #36351
Comments
@nodejs/modules |
targos
added
the
esm
Issues and PRs related to the ECMAScript Modules implementation.
label
Dec 6, 2020
this is a bug in v8 that they have been very unenthusiastic about fixing. |
Closed
21 tasks
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
3 tasks
In Node.js v22 this is no longer the case AFAICT:
|
The host defined options leak in the compilation cache has already been fixed by V8. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
What do you see instead?
Additional information
vm.SourceTextModule
is caching theimportModuleDynamically
callback as long as the source code is the same, where asinitializeImportMeta
does not.If how
importModuleDynamically
does its work depends on an external state, often in test suite, it will load modules inconsistently to those state and cause discrepancies as viewed inside the VM modules.The text was updated successfully, but these errors were encountered: