http2 stream.end error

[ariran5]

• Version: 15.5.1
• Platform: Darwin MacBook-Pro.local 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64

What steps will reproduce the bug?

// index.mjs

import http2 from 'http2'
import fs from 'fs'

const server = http2.createSecureServer({
  key: fs.readFileSync('localhost-privkey.pem'),
  cert: fs.readFileSync('localhost-cert.pem')
})

server.on('error', (err) => console.error(err))

server.on('stream', (stream, headers, flags) => {
  stream.end('qweqwe ds sdoapskd okqdoeik woik ed'.repeat(80), err => {
    if (err) {
      console.error(err) // always shows error on each request
      return
    }
    console.log('qweqwe')
  })
});

server.listen(8444) // https://localhost:8444

Error [ERR_STREAM_DESTROYED]: Cannot call end after a stream was destroyed
    at new NodeError (node:internal/errors:278:15)
    at errorBuffer (node:internal/streams/writable:527:14)
    at afterWrite (node:internal/streams/writable:507:5)
    at onwrite (node:internal/streams/writable:483:7)
    at done (node:internal/http2/core:2081:7)
    at WriteWrap.writeCallback [as callback] (node:internal/http2/core:2086:7)
    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:89:12) {
  code: 'ERR_STREAM_DESTROYED'
}

What is the expected behavior?

Works without errors

What do you see instead?

Always shows errors on each response in stream.end callback

[kingyyy]

same here

[Ayase-252]

Reproducable in Node v15.12.0. Also Reproducable in v15.0.0

➜  node git:(triaging/issue-37866) ✗ node -v
v15.12.0
➜  node git:(triaging/issue-37866) ✗ node issues/http2-36860.mjs 
Error [ERR_STREAM_DESTROYED]: Cannot call end after a stream was destroyed
    at new NodeError (node:internal/errors:329:5)
    at errorBuffer (node:internal/streams/writable:527:14)
    at afterWrite (node:internal/streams/writable:507:5)
    at onwrite (node:internal/streams/writable:483:7)
    at done (node:internal/http2/core:2087:7)
    at WriteWrap.writeCallback [as callback] (node:internal/http2/core:2092:7)
    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:87:12) {
  code: 'ERR_STREAM_DESTROYED'
}
Error [ERR_STREAM_DESTROYED]: Cannot call end after a stream was destroyed
    at new NodeError (node:internal/errors:329:5)
    at errorBuffer (node:internal/streams/writable:527:14)
    at afterWrite (node:internal/streams/writable:507:5)
    at onwrite (node:internal/streams/writable:483:7)
    at done (node:internal/http2/core:2087:7)
    at WriteWrap.writeCallback [as callback] (node:internal/http2/core:2092:7)
    at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:87:12) {
  code: 'ERR_STREAM_DESTROYED'
}

But it works without issue in v14.15.5 and v14.16.0.

EDIT: delete duplicated comment due to bad connection

[Kalmuraee]

I have the same issue, I was assuming updating to 15.14.0 would solve the issue, but it didn't.

[acolle]

Any updates on that one?
I'm having the same issue on 15.9.0.
Thanks

[valipopescu]

I have the same issue in 16.2.

[Ayase-252]

cc @nodejs/http2

[bl-ue]

If this is a bug, I'll try to open a PR to fix it.

[bl-ue]

Reproducible in master (65a7fd3).
There were a few semver-major http2-related PRs shipped with v15, #34664, #33161, #33535, #33193, and a few http-related semver-major PRs #33405, #33172, #31818. I'll bisect.