Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky test-fs-utimes in CI on Pi2 #37692

Open
Trott opened this issue Mar 10, 2021 · 4 comments
Open

investigate flaky test-fs-utimes in CI on Pi2 #37692

Trott opened this issue Mar 10, 2021 · 4 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.

Comments

@Trott
Copy link
Member

Trott commented Mar 10, 2021

Originally posted by @mhdawson in #36591 (comment)

Failed in CI as well: https://ci.nodejs.org/job/node-test-binary-arm-12+/lastCompletedBuild/RUN_SUBSET=0,label=pi2-docker/testReport/(root)/test/parallel_test_fs_utimes/ although with different error:

ode:assert:399
    throw err;
    ^

AssertionError [ERR_ASSERTION]: FAILED: expect_errno [Arguments] {
  '0': 'futimesSync',
  '1': 22,
  '2': AssertionError [ERR_ASSERTION]: FAILED: expect_ok [Arguments] {
    '0': 'futimesSync',
    '1': 22,
    '2': undefined,
    '3': '123456',
    '4': -1
  }
       check_mtime: 2.3949999809265137
      at expect_ok (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:64:3)
      at syncTests (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:142:7)
      at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:120:11
      at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:377:15
      at FSReqCallback.oncomplete (node:fs:184:23) {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: undefined,
    expected: true,
    operator: '=='
  },
  '3': 'ENOSYS'
}
    at expect_errno (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:56:3)
    at syncTests (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:144:7)
    at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:120:11
    at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:377:15
    at FSReqCallback.oncomplete (node:fs:184:23) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
@Trott
Copy link
Member Author

Trott commented Mar 10, 2021

CI failure again:

https://ci.nodejs.org/job/node-test-binary-arm-12+/9681/RUN_SUBSET=3,label=pi2-docker/console

00:39:33 not ok 229 parallel/test-fs-utimes
00:39:33   ---
00:39:33   duration_ms: 4.757
00:39:33   severity: fail
00:39:33   exitcode: 1
00:39:33   stack: |-
00:39:33     node:assert:402
00:39:33         throw err;
00:39:33         ^
00:39:33     
00:39:33     AssertionError [ERR_ASSERTION]: FAILED: expect_ok [Arguments] {
00:39:33       '0': 'futimes',
00:39:33       '1': 22,
00:39:33       '2': null,
00:39:33       '3': '123456',
00:39:33       '4': -1
00:39:33     }
00:39:33          check_mtime: 2.0460000038146973
00:39:33         at expect_ok (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:64:3)
00:39:33         at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-utimes.js:118:11
00:39:33         at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:376:15
00:39:33         at FSReqCallback.oncomplete (node:fs:190:23) {
00:39:33       generatedMessage: false,
00:39:33       code: 'ERR_ASSERTION',
00:39:33       actual: null,
00:39:33       expected: true,
00:39:33       operator: '=='
00:39:33     }
00:39:33   ...

@aduh95
Copy link
Contributor

aduh95 commented Sep 6, 2024

Cannot reproduce on macOS

$ tools/test.py --repeat 9999 test/parallel/test-fs-utimes.js -t 9 
[07:05|% 100|+ 9999|-   0]: Done                  

All tests passed.

@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

I was able to reproduce on ubuntu by testing a theory... I ran a couple other parallel processes to stress the host and then ran the test. The flake here may be caused by too much running in parallel. I suggest we try moving the test to sequential and see if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

No branches or pull requests

4 participants