TLSSocket.setMaxSendFragment results in an abort

[zyscoder]

• Version: v16.0.0-pre
• Platform: Linux 5.8.0-38-generic The binary and long term compatibility with node #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: TLSSocket.setMaxSendFragment

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

new tls.TLSSocket().setMaxSendFragment();

Then the node instance occurs an abort.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v16.0.0-pre.
Type ".help" for more information.
> new tls.TLSSocket().setMaxSendFragment();
/home/zys/Toolchains/node/node[97452]: ../src/crypto/crypto_tls.cc:2010:static void node::crypto::TLSWrap::SetMaxSendFragment(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args.Length() >= 1 && args[0]->IsNumber()' failed.
 1: 0x565026d33af4 node::Abort() [/home/zys/Toolchains/node/node]
 2: 0x565026d33b88  [/home/zys/Toolchains/node/node]
 3: 0x565026ef3edc node::crypto::TLSWrap::SetMaxSendFragment(v8::FunctionCallbackInfo<v8::Value> const&) [/home/zys/Toolchains/node/node]
 4: 0x565026fb2167 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/zys/Toolchains/node/node]
 5: 0x565026fb2f10  [/home/zys/Toolchains/node/node]
 6: 0x565026fb3507  [/home/zys/Toolchains/node/node]
 7: 0x565026fb379a v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/zys/Toolchains/node/node]
 8: 0x565027951259  [/home/zys/Toolchains/node/node]
[1]    97452 abort (core dumped)  /home/zys/Toolchains/node/node                                                                                                                                                                                       

Additional information

[Ayase-252]

Since it is a duplicate of #38169 and will be fixed if #38170 lands, I'm closing the issue for now. Feel free to reopen it if you have further concern about the issue

[zyscoder]

Sorry for my carelessness.

[Ayase-252]

It is always appreciated to send bug reports. Just do what you want 👍