Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented readline methods #3836

Closed
sindresorhus opened this issue Nov 15, 2015 · 6 comments
Closed

Undocumented readline methods #3836

sindresorhus opened this issue Nov 15, 2015 · 6 comments
Labels
doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.

Comments

@sindresorhus
Copy link

There are several exposed methods on readline that are not documented:

They should IMHO either be documented or made internal. Preferably the latter.

Most of these are already modules on npm anyways:

@r-52 r-52 added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. feature request Issues that request new features to be added to Node.js. labels Nov 15, 2015
@mscdex mscdex removed the feature request Issues that request new features to be added to Node.js. label Nov 15, 2015
@tejasmanohar
Copy link

@sindresorhus Just submitted a PR for these.

@Fishrock123
Copy link
Contributor

PR: #3847

@cjihrig
Copy link
Contributor

cjihrig commented Nov 19, 2015

I'm going to keep this open, as #3862 doesn't cover readline.emitKeypressEvents(). On the last CTC call, the discussion to deprecate or document this function was tabled.

@cjihrig cjihrig reopened this Nov 19, 2015
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

@cjihrig ... do we still need to keep this one open?

@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

@jasnell I'll submit a PR to address this so that it can be closed one way or the other.

@cjihrig
Copy link
Contributor

cjihrig commented Apr 5, 2016

Documented in 3de9bc9.

@cjihrig cjihrig closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

No branches or pull requests

7 participants