Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiredis node-gyp build doesn't work #386

Closed
RyanK1m opened this issue Jan 14, 2015 · 2 comments
Closed

hiredis node-gyp build doesn't work #386

RyanK1m opened this issue Jan 14, 2015 · 2 comments

Comments

@RyanK1m
Copy link

RyanK1m commented Jan 14, 2015

I think this is similar issue with bcrypt, but npm install hiredis doesn't work on iojs 1.0.1

List of errors

  • no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
  • redefinition of 'NanNew'
  • no member named 'IsExternalAscii' in 'v8::String'; did you mean 'IsExternal'?
  • no member named 'GetExternalAsciiStringResource' in 'v8::String'; did you mean 'GetExternalOneByteStringResource'?
  • assigning to 'const v8::String::ExternalStringResource *' from incompatible type 'const v8::String::ExternalOneByteStringResource *'
  • assigning to 'const char *' from incompatible type 'const uint16_t *' (aka 'const unsigned short *')

Cheers!

@ckaatz-here
Copy link

seen the same today with zmq

hild_process: customFds option is deprecated, use stdio instead.
make: Entering directory /usr/lib/node_modules/zmq/build' CXX(target) Release/obj.target/zmq/binding.o In file included from ../binding.cc:36: ../node_modules/nan/nan.h:481: error: ‘NanNew’ declared as an ‘inline’ variable ../node_modules/nan/nan.h:481: warning: ‘always_inline’ attribute ignored ../node_modules/nan/nan.h:481: error: ‘v8::Local<v8::String> NanNew’ redeclared as different kind of symbol ../node_modules/nan/nan.h:475: error: previous declaration of ‘v8::Local<v8::String> NanNew(v8::String::ExternalStringResource*)’ ../node_modules/nan/nan.h:481: error: ‘ExternalAsciiStringResource’ is not a member of ‘v8::String’ ../node_modules/nan/nan.h:481: error: ‘resource’ was not declared in this scope ../node_modules/nan/nan.h: In function ‘bool _NanGetExternalParts(v8::Handle<v8::Value>, const char**, size_t*)’: ../node_modules/nan/nan.h:2103: error: ‘class v8::String’ has no member named ‘IsExternalAscii’ ../node_modules/nan/nan.h:2104: error: expected initializer before ‘*’ token ../node_modules/nan/nan.h:2105: error: ‘ext’ was not declared in this scope ../node_modules/nan/nan.h:2105: error: ‘class v8::String’ has no member named ‘GetExternalAsciiStringResource’ make: *** [Release/obj.target/zmq/binding.o] Error 1 make: Leaving directory/usr/lib/node_modules/zmq/build'

@bnoordhuis
Copy link
Member

This has been fixed in nan, a new (1.6) release will be made later today. After that, it's up to module authors to update nan and publish a new version.

Closing, not an io.js issue per se. If I have time tonight, I'll send around some PRs to update the most popular projects. (Don't let that anyone stop from doing the same.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants