-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
req.headers is missing propertyIsEnumerable in http2 server #40263
Comments
This is normal and ok, req.headers do not have a prototype. It's the same in both http/1 and http/2. |
Lines 108 to 120 in d3162da
node/lib/internal/http2/compat.js Lines 316 to 319 in d3162da
|
@ronag wdyt? If I recall correctly we set the headers with |
I think we should not have prototype. I don't think it matters so much but I think we should choose whatever has best perf. |
Thanks for the clarification, need to handle this in fastify-multipart then. |
Version
14.18.0
Platform
linux
Subsystem
http2
What steps will reproduce the bug?
Start a http2 server and query it with
curl -v --http2-prior-knowledge http://localhost:8080
Console output should show that
propertyIsEnumerable
is a function but it is undefined. For http server the function is present.How often does it reproduce? Is there a required condition?
always
What is the expected behavior?
The
req.headers
object should havepropertyIsEnumerable
as a functionWhat do you see instead?
The
req.headers
object does not havepropertyIsEnumerable
functionAdditional information
This happens in 14.18.0 but not in 14.17.x
The text was updated successfully, but these errors were encountered: