-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify where pull requests should go #407
Comments
Send all patches here :) |
I think this is up to the contributor. Of course @mikeal wants you to land it here! 😉 |
But what's best for the ecosystem? Submitting it to both then? |
If it lands in joyent/node and it's noteworthy / useful enough, we'll eventually cherry-pick it into io.js. joyent/node is not known for high speed patch reviews, however; that's one of the reasons io.js exists. |
This was referenced Mar 7, 2020
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the large overlap of codebase between Node.js and io.js, it is often not easy for contributors to understand where to send patches. For instance, the two pull requests below express the exact same changes in the different projects:
What is the proper procedure?
Only create one pull request (where?) and hope it eventually gets merged in both?
Or create to pull requests like I have just done?
Maybe it would be good to clarify this in the contributors guidelines.
The text was updated successfully, but these errors were encountered: