Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers tarball way too big for 17.x+ #42086

Closed
rvagg opened this issue Feb 23, 2022 · 3 comments
Closed

Headers tarball way too big for 17.x+ #42086

rvagg opened this issue Feb 23, 2022 · 3 comments
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@rvagg
Copy link
Member

rvagg commented Feb 23, 2022

Version

17.x

Platform

headers

Subsystem

src

What steps will reproduce the bug?

Continuing on from nodejs/build#2695 (copying my latest comment there):

root@test-digitalocean-ubuntu1804-x64-1:/home/iojs/.cache/node-gyp/18.0.0-nightly20220222c071bd581a/include/node/openssl/archs# ls
BSD-x86     VC-WIN64-ARM  aix64-gcc       darwin64-arm64-cc   linux-armv4  linux-ppc64    linux32-s390x    linux64-s390x
BSD-x86_64  VC-WIN64A     aix64-gcc-as    darwin64-x86_64-cc  linux-elf    linux-ppc64le  linux64-mips64   solaris-x86-gcc
VC-WIN32    aix-gcc       darwin-i386-cc  linux-aarch64       linux-ppc    linux-x86_64   linux64-riscv64  solaris64-x86_64-gcc
root@test-digitalocean-ubuntu1804-x64-1:/home/iojs/.cache/node-gyp/18.0.0-nightly20220222c071bd581a/include/node/openssl/archs# du -sh .
61M     .

Also https://nodejs.org/download/release/latest-v16.x/

node-v16.14.0-headers.tar.gz                       08-Feb-2022 12:46              560771

vs

https://nodejs.org/download/release/latest-v17.x/

node-v17.6.0-headers.tar.gz                        22-Feb-2022 22:38             9923593

on the latest 18.x nightly it's even up to 10028309 bytes now! These files were supposed to be small and lean for node-gyp to download and use to compile addons. They're now the size of 0.12 binary tarballs!

I'm not sure of the exact solution to this, I don't know how much of these arch specific headers are required, but this is neither sustainable for our infra not ideal for users.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Additional information

No response

@rvagg
Copy link
Member Author

rvagg commented Feb 23, 2022

cc @nodejs/crypto I guess

@richardlau
Copy link
Member

Duplicate of #42081.

@rvagg
Copy link
Member Author

rvagg commented Feb 23, 2022

sorry, dupe of #42081 I guess

@rvagg rvagg closed this as completed Feb 23, 2022
@richardlau richardlau added build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. openssl Issues and PRs related to the OpenSSL dependency. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

No branches or pull requests

2 participants