Grant triagers the ability to re-run a failed CI

[meixg]

What is the problem this feature will solve?

I see CI sometimes gets flaky, and the PR author has to find a collaborator to re-run it. Maybe triagers can help with that too?

Triage now can add the request-ci label to PRs, but it will completely re-run a CI from zero.

What is the feature you are proposing to solve the problem?

Grant triagers the ability to the resume build option.

What alternatives have you considered?

Or maybe request-ci label can be processed more smartly.

[gireeshpunathil]

ref: https://github.com/orgs/nodejs/teams/issue-triage/discussions/1?from_comment=9#discussion-1-comment-9

in terms of what would happen on this request, IMO:

• a quick TSC review to ratify this request based on our access policy
• decide which way to go: access to CI for triagers versus overloading the CI bot
• find a sponsor for the feature (I am happy to be one) and an interested party to implement.

will try to discuss in next TSC sitting.

[aduh95]

Duplicate of #40817.

[gireeshpunathil]

Duplicate of #40817.

may be duplicate in terms of part of the solution, but not the underlying problem?

[aduh95]

Duplicate of #40817.

may be duplicate in terms of part of the solution, but not the underlying problem?

Yeah I guess duplicate is not the correct word, the other issue could be merged into this one as this one is more general. In any case, I think #40817 (comment) also applies here and should be addressed before we move forward with this request.

[benjamingr]

I think the current triagers program doesn't make sense to me in its current format.

Luckily I think that's because it's "too successful" in that triagers eventually makes collaborator (I certainly intend to nominate meixg if they keep up making meaningful PRs and are interested - which is not a sure thing but I'm pretty confident).

I am wondering if it wouldn't make more sense to rename the triagers team to a "collaborator internship" or "collaborator mentoring" or incubation and something similar?

That would frame giving triagers more collaborator tools like better control of how/what CI to run when.

On an unrelated note we do need to be careful since currently if triagers can add labels to pull request they can effectively land stuff with ncu. They are however unable to reverse any mistakes NCU might make because they can't force-push fixes to master to correct mistakes which can be sometimes necessary.

[gireeshpunathil]

I think the current triagers program doesn't make sense to me in its current format.

pls propose amendments in a separate issue, even if it is just to rename the team name.

we do need to be careful since currently if triagers can add labels to pull request they can effectively land stuff with ncu.

triagers can already add labels. their role definition does not contain landing stuff. there wasn't any role abuse of in the past.

[benjamingr]

@gireeshpunathil where should such an issue be open? In nodejs/node or nodejs/admin?

pls propose amendments in a separate issue, even if it is just to rename the team name.

I think this is relevant since if it's the "collaborator-interns" or "collaborators-in-training" or similar team then giving them full CI access makes perfect sense to me as well as other collaborator like priviledges.

triagers can already add labels. their role definition does not contain landing stuff. there wasn't any role abuse of in the past.

Yes though I suspect the ability to trigger CI and land stuff is something that triagers got happenstance as a side-effect of their ability to add labels right?

[gireeshpunathil]

@benjamingr -

• in terms of the target repo, I would think core repo
• in terms of team name, I guess not all triagers would want to become collaborators (at least by definition)
• in terms of CI access as a side effect of label - agree.

[gireeshpunathil]

so in terms of policy, TSC gave the green signal - triagers are officially allowed to run fresh and re-run of CI, through existing or new labels.

If anyone is interested to implement resume-ci label, pls let me know or go ahead!

[meixg]

so in terms of policy, TSC gave the green signal - triagers are officially allowed to run fresh and re-run of CI, through existing or new labels.

If anyone is interested to implement resume-ci label, pls let me know or go ahead!

I'm willing to implement this, but I guess this needs to have access to Jenkins?

[gireeshpunathil]

but I guess this needs to have access to Jenkins?

I am not 100% sure on this, @richardlau - any pointers here?

[gireeshpunathil]

removing the tsc-agenda label, as it was discussed there and the purpose is met

[richardlau]

but I guess this needs to have access to Jenkins?

I am not 100% sure on this, @richardlau - any pointers here?

You will need to extend node-core-utils's ncu-ci command so will almost certainly need a Jenkins token to test with (i.e. as you need to run the existing ncu-ci run <pr_id> for starting CI). The best way to implement this is show that running, say ncu-ci resume <pr_id> (where resume is your new addition), will resume the latest CI run for pull request <pr_id> -- once that can be demonstrated it can be added to a GitHub workflow triggered on label change.