Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about abstract URL to an standalone C++ repo just like what http-parser does? #42545

Closed
XadillaX opened this issue Mar 31, 2022 · 5 comments
Labels
feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@XadillaX
Copy link
Contributor

What is the problem this feature will solve?

To make code more clean and beautiful.

What is the feature you are proposing to solve the problem?

To make code more clean and beautiful.

What alternatives have you considered?

We may abstract the C++ code, just like http-parse does. Or like https://github.com/cpp-netlib/url.

@XadillaX XadillaX added the feature request Issues that request new features to be added to Node.js. label Mar 31, 2022
@mscdex
Copy link
Contributor

mscdex commented Mar 31, 2022

To make code more clean and beautiful.

Why does that require a separate repo?

@XadillaX
Copy link
Contributor Author

XadillaX commented Apr 1, 2022

To make code more clean and beautiful.

Why does that require a separate repo?

I saw the logic quite independent. Maybe we can increase maintainability by separating? And also, we can make that logic reusable for the whole open source community.

I'm extracting that via my own repo: https://github.com/XadillaX/libwhatwgurl

@RaisinTen
Copy link
Contributor

I think people were in favor of turning the WHATWG URL parser into a vendored dependency in #38708. Does it make sense to take this discussion there?

@VoltrexKeyva VoltrexKeyva added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Apr 1, 2022
@targos targos moved this to Pending Triage in Node.js feature requests Apr 4, 2022
@RaisinTen
Copy link
Contributor

@XadillaX it seems the discussion has already moved to the other issue. Does this need to stay open?

@legendecas legendecas moved this from Pending Triage to Closed in Node.js feature requests Jun 2, 2022
@XadillaX
Copy link
Contributor Author

XadillaX commented May 7, 2023

Since Node.js already used ada for new URL parser. I think https://github.com/XadillaX/libwhatwgurl is no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

No branches or pull requests

4 participants