-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How about abstract URL
to an standalone C++ repo just like what http-parser does?
#42545
Comments
Why does that require a separate repo? |
I saw the logic quite independent. Maybe we can increase maintainability by separating? And also, we can make that logic reusable for the whole open source community. I'm extracting that via my own repo: https://github.com/XadillaX/libwhatwgurl |
I think people were in favor of turning the WHATWG URL parser into a vendored dependency in #38708. Does it make sense to take this discussion there? |
@XadillaX it seems the discussion has already moved to the other issue. Does this need to stay open? |
Since Node.js already used ada for new URL parser. I think https://github.com/XadillaX/libwhatwgurl is no longer applicable. |
What is the problem this feature will solve?
To make code more clean and beautiful.
What is the feature you are proposing to solve the problem?
To make code more clean and beautiful.
What alternatives have you considered?
We may abstract the C++ code, just like http-parse does. Or like https://github.com/cpp-netlib/url.
The text was updated successfully, but these errors were encountered: