Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: mark it as stable #43294

Open
tony-go opened this issue Jun 2, 2022 · 1 comment
Open

trace_events: mark it as stable #43294

tony-go opened this issue Jun 2, 2022 · 1 comment
Labels
doc Issues and PRs related to the documentations. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Comments

@tony-go
Copy link
Member

tony-go commented Jun 2, 2022

Affected URL(s)

https://nodejs.org/dist/latest-v18.x/docs/api/tracing.html

Description of the problem

Hey 👋

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

We want to promote this tool to tier one (Ref), but it seems impossible as the API is still marked as experimental. So then we thought that it could be nice to discuss its status, and potentially mark it as stable.

A few facts

  • The module has been there for a while: 4 years and one month (Ref)
  • Last API change: 1 year and 4 months (Ref)

Question marks

  • Do we have good test coverage for it? I saw this file. Do you think that we cover enough cases? I'll take a look, but feel free to share any thoughts.
  • Evidence of usage in the field? No doubt on my side regarding the CLI, but regarding the API, I don't know. Any thoughts?

cc @nodejs/diagnostics

@tony-go tony-go added the doc Issues and PRs related to the documentations. label Jun 2, 2022
@RaisinTen
Copy link
Contributor

I don't think there's a lot of usage of the trace_events module in the ecosystem (at least not much outside forks of node on https://cs.github.com).
The CLI currently produces traces in the chrome json tracing format which is considered legacy. I think we should move to using Perfetto before marking this as stable. FYI, even chromium started producing Perfetto startup traces by default after https://chromium-review.googlesource.com/c/chromium/src/+/3038802 landed.

@VoltrexKeyva VoltrexKeyva added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Development

No branches or pull requests

3 participants