-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is maintaining-zlib document up-to-date? #44254
Comments
@nodejs/zlib |
AFAIK the document is up-to-date, it's just that upstream made a lot of changes to the build config and this line is all about it:
There have been multiple attempts to update zlib without success so far (I think it's mostly a question of time and C/build knowledge): #33044, #41745, #42570, #42571 My branch for #41745 went quite far, but there were performance concerns which I'm unable to handle. |
Ok, thanks! I'll look at it and work soon as I have time. I'll keep this issue posted, probably we would need to update the document as well. |
To follow this ticket :) |
I'm closing this as #45387 landed. Please comment or reopen if needed. |
Pretty soon we'll need to update the
zlib
version (see nodejs/security-wg#824). I've tried to update it locally following the maintaining-zlib document, but things get breaking (it seems arch issues -- I'm on Linux).Is it up-to-date? If not, how can I update it?
cc: @targos @sam-github
The text was updated successfully, but these errors were encountered: