Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable node_modules lookup for all subpaths of builtin modules #44651

Open
targos opened this issue Sep 15, 2022 · 0 comments
Open

Disable node_modules lookup for all subpaths of builtin modules #44651

targos opened this issue Sep 15, 2022 · 0 comments
Labels
module Issues and PRs related to the module subsystem.

Comments

@targos
Copy link
Member

targos commented Sep 15, 2022

Something else discussed in #44250 that we should consider is making new subpath additions (like any other core module getting /promises) allowable as semver-minor. This might be a code change, to ensure that nonexistent subpaths (like process/promises) throw rather than try to resolve to something like node_modules/process/promises; but once that’s done we should update the docs accordingly.

Originally posted by @GeoffreyBooth in #44576 (comment)
@targos targos mentioned this issue Sep 15, 2022
Closed
@GeoffreyBooth GeoffreyBooth added module Issues and PRs related to the module subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Sep 15, 2022
@aduh95 aduh95 removed the esm Issues and PRs related to the ECMAScript Modules implementation. label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GeoffreyBooth @targos @aduh95