Request cherry-pick of V8 commit, re-enabling [[Scopes]] internal property

[AaronFriel]

Version

19.2

What steps will reproduce the bug?

Pulumi's Node.js SDK has a capability for capturing and serializing closures, which utilizes an internal property on functions called [[Scopes]], which is accessible via runtime methods. This was removed from upstream V8, however we've requested that this be reverted and that process is underway.

Our tracking issue:

• Function serialization broken in NodeJS 19.2 pulumi/pulumi#11488

Chromium issue and revert comment: https://bugs.chromium.org/p/chromium/issues/detail?id=1365858#c13

How often does it reproduce? Is there a required condition?

Always, this is an upstream feature change in V8.

What is the expected behavior?

No response

What do you see instead?

n/a

Additional information

No response

[bnoordhuis]

As a workaround, pass --noexperimental_remove_internal_scopes_property on the command line.

[AaronFriel]

@bnoordhuis Is there an equivalent environment variable we could use? Passing that argument on earlier Node versions results in:

node: bad option: --noexperimental_remove_internal_scopes_property

[bnoordhuis]

Alas, no.

[AaronFriel]

Ah that's a shame, Pulumi supports all supported Node runtimes.

I'm a bit leery of baking in knowledge into our CLI about this property and trying to do feature detection via node --v8-options. Do you have an idea of how long it would take for this revert to land in Node?

[bnoordhuis]

Probably not before January. #45831 is scheduled for tomorrow and I expect that's the last v19.x release of 2022.

[AaronFriel]

That would hopefully have this land in 19.4?

We will direct users to stick to active & LTS versions of Node until this lands.

[bnoordhuis]

Yes, or (hypothetically) v19.3.1. You will want to open a pull request with the cherry-pick, however. :-)

[AaronFriel]

Happy to do that, what's the process for making that PR & cherry-pick?

[bnoordhuis]

It's described here: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-V8.md

[AaronFriel]

@bnoordhuis Seems like that went smoothly, though some of that documentation seemed out of date - specifically about the branches and references to Node v4, v5.

Please let me know on the PR if there's anything else for me to do!

#45851

[targos]

#45851 landed and will be part of the next 19.x release.