Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip tab and newline from URL's protocol setter #46332

Closed
annevk opened this issue Jan 24, 2023 · 2 comments
Closed

Strip tab and newline from URL's protocol setter #46332

annevk opened this issue Jan 24, 2023 · 2 comments
Assignees
@anonrig
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@annevk
Copy link

annevk commented Jan 24, 2023

Corrected tests: web-platform-tests/wpt#38032.

Context: whatwg/url#609.
@annevk annevk mentioned this issue Jan 24, 2023
Closed
@benjamingr
Copy link
Member

Thanks! @nodejs/url

There is also ongoing work on a new URL parser for Node so pinging @anonrig to also take a look :)

@benjamingr benjamingr added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 24, 2023
@anonrig
Copy link
Member

anonrig commented Jan 25, 2023

I don't think the tests are correct for this change. I opened an issue: web-platform-tests/wpt#38182

@anonrig anonrig self-assigned this Jan 26, 2023
@anonrig anonrig mentioned this issue Feb 3, 2023
Closed
@anonrig anonrig closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anonrig anonrig

Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: replace url parser with Ada anonrig/node
3 participants
@benjamingr @annevk @anonrig