Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcautil.h is missing #47060

Closed
vladimir-andreevich opened this issue Mar 13, 2023 · 1 comment
Closed

wcautil.h is missing #47060

vladimir-andreevich opened this issue Mar 13, 2023 · 1 comment

Comments

@vladimir-andreevich
Copy link

vladimir-andreevich commented Mar 13, 2023

Version

v14.19.3

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

No response

What steps will reproduce the bug?

  1. Open tools/msvs/msi/nodemsi.sln
  2. Build a WiX solution using a local Windows debugger for the target x64 or x86.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

Visual Studio IDE makes WiX Node.JS installers for Windows.

What do you see instead?

Error code C1083 in custom_actions.cc, line 5: Cannot include file wcautil.h: No such file or directory.

Additional information

WiX toolset v3.11

@StefanStojanovic
Copy link
Contributor

The Node.js installer is built from vcbuild.bat with this command https://github.com/nodejs/node/blob/main/vcbuild.bat#L535. Since you are trying to build it from Visual Studio IDE, MSBuild is not getting all of the required properties. I suggest you try building the MSI installer by running vcbuild.bat release x64 msi

@nodejs nodejs locked and limited conversation to collaborators Mar 13, 2023
@bnoordhuis bnoordhuis converted this issue into discussion #47061 Mar 13, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants