libc++abi: terminating due to uncaught exception of type std::out_of_range: basic_string Abort trap: 6

[Leask]

Version

v20.0.0

Platform

Darwin Flora.local 22.5.0 Darwin Kernel Version 22.5.0: Tue Apr 25 04:06:50 PDT 2023; root:xnu-8796.121.2~8/RELEASE_ARM64_T6020 arm64

Subsystem

URL

What steps will reproduce the bug?

When creating a URL object with some invalid url strings, it's straightforward to reproduce:

new URL('..#', 'a:b');

libc++abi: terminating due to uncaught exception of type std::out_of_range: basic_string
Abort trap: 6

It was initially found in this use case: mozilla/readability#801

How often does it reproduce? Is there a required condition?

It can be reproduced every time on Linux and macOS as well.

What is the expected behavior? Why is that the expected behavior?

It should throw an error just like other invalid URLs.

Uncaught TypeError [ERR_INVALID_URL]: Invalid URL
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at new NodeError (node:internal/errors:399:5)
    at new URL (node:internal/url:719:13) {
  input: 'xxxxxxx',
  code: 'ERR_INVALID_URL'
}

What do you see instead?

libc++abi: terminating due to uncaught exception of type std::out_of_range: basic_string
Abort trap: 6

Additional information

N/A

[himself65]

/cc @nodejs/url

[himself65]

I think this is the issue of Ada 2.0

[Leask]

I think this is the issue of Ada 2.0

Reasonable.

[lemire]

Yes. It is from ada.

[lemire]

@anonrig Please review the potential fix.

[himself65]

➜  node git:(master) ./out/Debug/node   
Welcome to Node.js v21.0.0-pre.
Type ".help" for more information.
> new URL('..#', 'a:b');
Assert at line 5861 of file ../deps/ada/ada.h
FAIL: validate()
[1]    78476 abort      ./out/Debug/node

[lemire]

@himself65 Yes. We definitively had a bug in ada. I think @anonrig will push a fix.

[anonrig]

Released Ada v2.3.1 with the fix to this issue thanks to @lemire

[Leask]

Thank you all for fixing this issue. 👏