Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ada 2.5.x to v18 #48343

Closed
hoikin opened this issue Jun 5, 2023 · 2 comments
Closed

Upgrade Ada 2.5.x to v18 #48343

hoikin opened this issue Jun 5, 2023 · 2 comments
Assignees
@anonrig
Labels
feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@hoikin
Copy link

hoikin commented Jun 5, 2023

What is the problem this feature will solve?

Node 18.16 are have Ada 1.x version while 20 already using Ada 2.x. Version

What is the feature you are proposing to solve the problem?

Suspected some bug introduced by Ada since 18.16 caused a lot of Malloc error or double free error. The server will stop response and we need restart the server to accept request again

What alternatives have you considered?

Any workaround to turn off Ada parser in 18.x version
@hoikin hoikin added the feature request Issues that request new features to be added to Node.js. label Jun 5, 2023
@anonrig anonrig self-assigned this Jun 5, 2023
@anonrig
Copy link
Member

anonrig commented Jun 5, 2023

I'm opening a backport pull request.

@anonrig
Copy link
Member

anonrig commented Jun 5, 2023 •
edited
Loading

Suspected some bug introduced by Ada since 18.16 caused a lot of Malloc error or double free error. The server will stop response and we need restart the server to accept request again

Can you explain, and share a reproduction? What is the root cause of your suspicion?

@anonrig anonrig added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jun 5, 2023
@anonrig anonrig mentioned this issue Jun 5, 2023
Closed
19 tasks
@anonrig anonrig closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anonrig anonrig

Labels
feature request Issues that request new features to be added to Node.js. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anonrig @hoikin