Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextifyContext::PropertyDefinerCallback() never intercepts the request #52634

Open
isheludko opened this issue Apr 22, 2024 · 0 comments
Open
Labels
vm Issues and PRs related to the vm subsystem.

Comments

@isheludko
Copy link
Contributor

isheludko commented Apr 22, 2024

Version

v22.0.0-pre

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

While migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, v8#180) I noticed that ContextifyContext::PropertyDefinerCallback() never reports that it has intercepted the request.
It should have called args.GetReturnValue()->SetUndefined(); in define_prop_on_sandbox instead.

Fixing this issue exposes another one - ContextifyContext::PropertyEnumeratorCallback() never returns symbol properties because ctx->sandbox()->GetPropertyNames(ctx->context()) skips symbols. There's a GetPropertyNames() overload with a PropertyFilter parameter which can be configured to not skip symbols.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

n/a

Additional information

No response

@joyeecheung joyeecheung added the vm Issues and PRs related to the vm subsystem. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants