You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, v8#180) I noticed that ContextifyContext::PropertyDefinerCallback() never reports that it has intercepted the request.
It should have called args.GetReturnValue()->SetUndefined(); in define_prop_on_sandbox instead.
Fixing this issue exposes another one - ContextifyContext::PropertyEnumeratorCallback() never returns symbol properties because ctx->sandbox()->GetPropertyNames(ctx->context()) skips symbols. There's a GetPropertyNames() overload with a PropertyFilter parameter which can be configured to not skip symbols.
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
n/a
Additional information
No response
The text was updated successfully, but these errors were encountered:
Version
v22.0.0-pre
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
While migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, v8#180) I noticed that
ContextifyContext::PropertyDefinerCallback()
never reports that it has intercepted the request.It should have called
args.GetReturnValue()->SetUndefined();
indefine_prop_on_sandbox
instead.Fixing this issue exposes another one -
ContextifyContext::PropertyEnumeratorCallback()
never returns symbol properties becausectx->sandbox()->GetPropertyNames(ctx->context())
skips symbols. There's aGetPropertyNames()
overload with aPropertyFilter
parameter which can be configured to not skip symbols.How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
n/a
Additional information
No response
The text was updated successfully, but these errors were encountered: