async_hooks: AsyncLocalStorage store does not get GC.

[mcollina]

For some unknown reasons, AsyncLocalStorage store object does not get gc'ed correctly:

'use strict'

const { test } = require('node:test')
const { AsyncLocalStorage } = require('node:async_hooks')
const { setImmediate } = require('node:timers/promises')
const assert = require('node:assert')

test('clone body garbage collection', async () => {
  const asyncLocalStorage = new AsyncLocalStorage()
  let ref = new WeakRef(new Map())

  await asyncLocalStorage.run(ref.deref(), async () => {})

  for (let i = 0; i < 1000; i++) {
    await setImmediate()
    global.gc(true)
  }

  assert.equal(ref.deref(), undefined, 'store was not garbage collected')
})

This test fails.

[mcollina]

cc @Qard @legendecas

[mcollina]

Closing, the test does not prove anything, as the following fails as well:

'use strict'

const { test } = require('node:test')
const { AsyncLocalStorage } = require('node:async_hooks')
const { setImmediate } = require('node:timers/promises')
const assert = require('node:assert')

test('clone body garbage collection', async () => {
  const asyncLocalStorage = new AsyncLocalStorage()
  let ref = new WeakRef(new Map())

  // await asyncLocalStorage.run(ref.deref(), async () => {})

  for (let i = 0; i < 1000; i++) {
    await setImmediate()
    global.gc(true)
  }

  assert.equal(ref.deref(), undefined, 'store was not garbage collected')
})

[Jamesernator]

Closing, the test does not prove anything, as the following fails as well:

The reason is global.gc(true) doesn't do a full collection, calling global.gc() instead passes the test as expected.

If this is meant to be a minimal replication of a AsyncLocalStorage holding things longer than it should, see this other issue I found with it.