Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/api/path.markdown needs a win32 example for path.format() #5671

Closed
Trott opened this issue Mar 12, 2016 · 4 comments
Closed

doc/api/path.markdown needs a win32 example for path.format() #5671

Trott opened this issue Mar 12, 2016 · 4 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. path Issues and PRs related to the path subsystem.

Comments

@Trott
Copy link
Member

Trott commented Mar 12, 2016

Good first time contribution for someone interested in such a thing...

@Trott Trott added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. good first issue Issues that are suitable for first-time contributors. labels Mar 12, 2016
@jvcjunior
Copy link

Hi @Trott , I would like to do this. Can I? I just need to add win32 example for path.format(pathObject) section? It would be my first contribution to node. ;)

@Trott
Copy link
Member Author

Trott commented Mar 14, 2016

@jvcjunior Yes, that's right, except that it looks like someone just submitted a pull request to fix this two hours ago.

However, if you want, you can try adding a Windows example for path.join() or path.normalize() or any other function you see in that document where a Windows example would be useful and is missing.

@jvcjunior
Copy link

Nice @Trott. Thank you for your suggestion and for help me out. I'll try then.

@Trott
Copy link
Member Author

Trott commented Mar 21, 2016

Closed in #5700

@Trott Trott closed this as completed Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants