Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-net-create-connection #6265

Closed
mscdex opened this issue Apr 19, 2016 · 8 comments
Closed

Investigate flaky test-net-create-connection #6265

mscdex opened this issue Apr 19, 2016 · 8 comments
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Comments

@mscdex
Copy link
Contributor

mscdex commented Apr 19, 2016

Example failure on pi2-raspbian-wheezy

Output:

# TIMEOUT
@mscdex mscdex added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Apr 19, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Apr 19, 2016

If this is only happening on the pi2's, it's possibly the same thing as #6133

@mscdex
Copy link
Contributor Author

mscdex commented Apr 19, 2016

@cjihrig Possibly, this is the first time I've personally spotted it.

@cjihrig cjihrig mentioned this issue Apr 19, 2016
Merged
1 task
@santigimeno
Copy link
Member

santigimeno commented Apr 21, 2016 •
edited
Loading

Running 4 stress test jobs with the code just before the ADDRCONFIG fix confirm the test was flaky (3 out of 4 fail):
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/665
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/666
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/667
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/668

@cjihrig
Copy link
Contributor

cjihrig commented Apr 21, 2016

What about with the ADDRCONFIG fix?

@santigimeno
Copy link
Member

@cjihrig running the stress tests now with current master:
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/669
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/670
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/671
https://ci.nodejs.org/job/node-stress-single-test/nodes=pi2-raspbian-wheezy/672

@cjihrig
Copy link
Contributor

cjihrig commented Apr 21, 2016

@santigimeno all green 💚

@santigimeno
Copy link
Member

Yeah :). Closing then!

@santigimeno
Copy link
Member

Fixed by #6281 landed in 54dd7c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @santigimeno @cjihrig