Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtrace probe removal broke Windows builds #698

Closed
rvagg opened this issue Feb 3, 2015 · 4 comments
Closed

dtrace probe removal broke Windows builds #698

rvagg opened this issue Feb 3, 2015 · 4 comments
Milestone
1.1.0

Comments

@rvagg
Copy link
Member

rvagg commented Feb 3, 2015

This is blocking release, I believe it's due to:

src: Remove unused Dtrace probes. #694

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/145/nodes=iojs-win2012r2/console

@thekemkid @bnoordhuis please address this, it'll hold up 1.1.0.
@rvagg rvagg added this to the v1.1.0 milestone Feb 3, 2015
@rvagg rvagg mentioned this issue Feb 3, 2015
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2015

@rvagg check out #700. If this is holding up the release and makes the CI happy, feel free to land it. Otherwise, feel free to close it.

@rvagg
Copy link
Member Author

rvagg commented Feb 3, 2015

will leave the call to @chrisdickinson on that as this is his release, I'm happy with a plain revert

@GlenTiki
Copy link
Contributor

GlenTiki commented Feb 3, 2015

You can revert it and I'll review the issue

@GlenTiki GlenTiki mentioned this issue Feb 3, 2015
Closed
@Fishrock123 Fishrock123 changed the title dtrace prove removal broke Windows builds dtrace probe removal broke Windows builds Feb 3, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2015

@rvagg can this be closed since #703 was merged?

@rvagg rvagg closed this as completed Feb 3, 2015
@jefeaguila jefeaguila mentioned this issue Feb 11, 2024
Open
@buzzlightyear726 buzzlightyear726 mentioned this issue Feb 11, 2024
Open
@jefeaguila jefeaguila mentioned this issue Feb 11, 2024
Open
@buzzlightyear726 buzzlightyear726 mentioned this issue Feb 11, 2024
Open
@Renukaloch Renukaloch mentioned this issue Feb 11, 2024
Open
@buzzlightyear726 buzzlightyear726 mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@rvagg @cjihrig @GlenTiki