Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Introduce CI builds to GitHub PR process #84

Closed
imjacobclark opened this issue Dec 5, 2014 · 4 comments · May be fixed by aliscco/alisco-node#31, Mcculloughj/node#16 or pratapadi/node#34
Closed

Comments

@imjacobclark
Copy link

We should be introducing CI builds to the GitHub PR process to verify code integrity, tests and coverage for those contributing to the codebase.

There are plenty out there, Travis-CI, Drone, Hosted Jenkins.

Thoughts?

@Fishrock123
Copy link
Contributor

@rvagg has been working on the io.js CI - see https://github.com/iojs/build

I'm pretty sure it was supposed to be enabled here but it doesn't seem to be?

@rvagg
Copy link
Member

rvagg commented Dec 6, 2014

We're getting there, it's just not a trivial process, it's the next big thing on my list of things to do and I'll be spending some time this month on making it happen.

Currently a limited set of people can trigger builds for any PR and I'm happy to expand that list to include any other people with commit access to io.js if they want to help test incomings.

Another problem we have is that the test suite isn't quite solid enough yet and will result in a lot of false positives, we've been working on that and it's something that will improve over time as we start to get frustrated with them.

@jbergstroem
Copy link
Member

Additionally, it'd be great to get the build status on the branch page as well (especially if branches become part of the workflow).

@chrisdickinson
Copy link
Contributor

This is being tracked in an issue on iojs/build.

@ghost ghost mentioned this issue Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants