Official socket transfer support

[ghost]

I'm interested in an official way of transferring a socket from Node.js (net.Socket / tls.TLSSocket) representation to the native representation (file descriptor / SOCKET descriptor + SSL pointer).

This can be used to transfer a connection from JS land into an addon, and have the addon manage the connection way more efficient.

[Fishrock123]

Once you call .listen() you can access the net.Socket._handle property, which in turn has a fd property.

_handle and _handle.fd are unlikely to be removed, and definitely will not disappear without significant fanfare with prior deprecation and semver-major (still, very unlikely). You should be good to use it, even if it is undocumented.

[ghost]

Windows version has no .fd of its _handle.

[ghost]

#7627

[ghost]

I think the first step in solving this is to agree on an interface. When that is done, the implementation should be very simple. I know @bnoordhuis is against the idea of simply exposing the native SOCKET handle on Windows and he seems to prefer having a strictly transferring-only interface so that addons do not mess around with the internals of any still existing Node.js object.

[ghost]

Any kind of net.Socket.export((fd, ssl) => {
// Here we can do stuff to the fd and ssl pointers. Fd can be int or SOCKET
});

works perfectly for me

[Trott]

This can be used to transfer a connection from JS land into an addon,

@bnoordhuis @indutny @nodejs/streams @nodejs/n-api Thoughts on how to do it now, how a new feature might do it, whether it is something that should be done at all, whether or not this issue should remain open?

[mcollina]

I think the best way to do this is via uv_link_t, if that would ever be supported here. This is an issue also on core itsef, as I would love to not pass through JS to read data from TLS.

https://github.com/indutny/uv_link_t

I do not think that manipulating directly the fd and pointers is the way to go. Linking to the OpenSSL version that node use is impossible (I could not do it, maybe someone else can), so allowing this is not a good idea.

[bnoordhuis]

whether it is something that should be done at all

It's a pretty niche thing. Not saying no but there would probably only be a few users at best, making it not worthwhile to sink a lot of time into.

There's also the question of if you want to manage sockets yourself, why not create them yourself?

Linking to the OpenSSL version that node use is impossible

This has improved in the last year, see #6274.

[mcollina]

@bnoordhuis thanks!

[bnoordhuis]

It's been a year since this issue was filed and there doesn't seem to be a whole lot of interest, never mind the practical considerations.

#7627 was closed as well so I'll close this out too. Please reopen if you think this needs to be revisited.