Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update collaborator_guide to mention core-validate-commit #9328

Closed
srl295 opened this issue Oct 27, 2016 · 8 comments
Closed

doc: update collaborator_guide to mention core-validate-commit #9328

srl295 opened this issue Oct 27, 2016 · 8 comments
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Comments

@srl295
Copy link
Member

srl295 commented Oct 27, 2016

Subsystem: doc

…should mention @evanlucas ' https://github.com/evanlucas/core-validate-commit as a helpful tool in validating commit messages.

It could be helpful even for contributors also.

@srl295
Copy link
Member Author

srl295 commented Oct 27, 2016

not unrelated: nodejs/core-validate-commit#13

@Trott
Copy link
Member

Trott commented Oct 27, 2016

doc/onboarding.md too

@mscdex mscdex added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Oct 27, 2016
@tanujasawant
Copy link
Contributor

@mscdex I'd like to work on this issue. I'm a newbie in Open Source, should I know anything before I get started?
Thanks! :)

@sam-github
Copy link
Contributor

@Tanuja-Sawant read https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and give it a go, thanks!

@tanujasawant
Copy link
Contributor

Okay, thanks @sam-github
Can you tell me where do I make changes that will eventually modify https://nodejs.org/en/get-involved/development/#landing-pull-requests
Thanks! :)

@gibfahn
Copy link
Member

gibfahn commented Nov 1, 2016

@Tanuja-Sawant You want the nodejs.org repo, that section is: https://github.com/nodejs/nodejs.org/blob/c8baa35c5b752fa7151da4ea22fab0b493f6a997/locale/en/get-involved/development.md#landing-pull-requests

It looks like that page is pretty similar to some of the stuff in https://github.com/nodejs/node/blob/add885416f38020f84b544b3cc0be28d6cf59bdc/COLLABORATOR_GUIDE.md#landing-pull-requests , they may well have got out of sync and need updating.

@tanujasawant
Copy link
Contributor

tanujasawant commented Nov 1, 2016

@gibfahn Oh I just saw your comment after creating a PR for other doc files. The page you referred me to is included in the code of nodejs/nodejs.org directory. Will it be apt to make changes of that file and make a PR here -in nodejs/node?
Thanks so much!

@gibfahn
Copy link
Member

gibfahn commented Nov 1, 2016

@Tanuja-Sawant You'll need to fork nodejs/nodejs.org and open a separate PR for changes to that Github repo, unfortunately Github needs 1 PR per repo.

So you'll end up with two Pull Requests, I'd include a link to the other Pull Request and to this issue in each Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

7 participants
@sam-github @mscdex @Trott @srl295 @tanujasawant @gibfahn and others