-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update collaborator_guide to mention core-validate-commit #9328
Comments
not unrelated: nodejs/core-validate-commit#13 |
|
@mscdex I'd like to work on this issue. I'm a newbie in Open Source, should I know anything before I get started? |
@Tanuja-Sawant read https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and give it a go, thanks! |
Okay, thanks @sam-github |
@Tanuja-Sawant You want the nodejs.org repo, that section is: https://github.com/nodejs/nodejs.org/blob/c8baa35c5b752fa7151da4ea22fab0b493f6a997/locale/en/get-involved/development.md#landing-pull-requests It looks like that page is pretty similar to some of the stuff in https://github.com/nodejs/node/blob/add885416f38020f84b544b3cc0be28d6cf59bdc/COLLABORATOR_GUIDE.md#landing-pull-requests , they may well have got out of sync and need updating. |
@Tanuja-Sawant You'll need to fork nodejs/nodejs.org and open a separate PR for changes to that Github repo, unfortunately Github needs 1 PR per repo. So you'll end up with two Pull Requests, I'd include a link to the other Pull Request and to this issue in each Pull Request. |
Subsystem: doc
COLLABORATOR_GUIDE
…should mention @evanlucas ' https://github.com/evanlucas/core-validate-commit as a helpful tool in validating commit messages.
It could be helpful even for contributors also.
The text was updated successfully, but these errors were encountered: