Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-icu-transcode fails built without intl #9511

Closed
shigeki opened this issue Nov 8, 2016 · 6 comments
Closed

test-icu-transcode fails built without intl #9511

shigeki opened this issue Nov 8, 2016 · 6 comments
Labels
good first issue Issues that are suitable for first-time contributors. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.

Comments

@shigeki
Copy link
Contributor

shigeki commented Nov 8, 2016

  • Version: v8.0.0-pre
  • Platform: all
  • Subsystem: test

test-icu-transcode fails built without intl as below.

$ ./configure --with-intl=none
$ make
$ ./node test/parallel/test-icu-transcode.js
/home/ohtsu/github/node/test/parallel/test-icu-transcode.js:19
  const dest = buffer.transcode(orig, 'utf8', test);
                      ^

TypeError: buffer.transcode is not a function
    at Object.<anonymous> (/home/ohtsu/github/node/test/parallel/test-icu-transcode.js:19:23)
    at Module._compile (module.js:573:32)
    at Object.Module._extensions..js (module.js:582:10)
    at Module.load (module.js:490:32)
    at tryModuleLoad (module.js:449:12)
    at Function.Module._load (module.js:441:3)
    at Module.runMain (module.js:607:10)
    at run (bootstrap_node.js:420:7)
    at startup (bootstrap_node.js:139:9)
    at bootstrap_node.js:535:3

This issue is reserved to be fixed in the course of Code and Learn in Node Fest Tokyo 2016.

Ref: nodejs/code-and-learn#58

@shigeki shigeki added test Issues and PRs related to the tests. good first issue Issues that are suitable for first-time contributors. labels Nov 8, 2016
@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Nov 8, 2016
@shigeki
Copy link
Contributor Author

shigeki commented Nov 18, 2016

No one worked in this issue so it is open to everyone.

@sotayamashita
Copy link
Contributor

It might be stupid question. buffer.transcode is added in: v7.1.0 ref. When I run test, is there any way to change version ?

@shigeki
Copy link
Contributor Author

shigeki commented Nov 18, 2016

@sotayamashita You can build Node and run tests on the master branch of the node repository in github which is already v8.0.0-pre .

@gbrmachado
Copy link

I'd like to take a look on it.

@sotayamashita
Copy link
Contributor

sotayamashita commented Nov 19, 2016

@shigeki I got it. I try to test and understand what intl and icu is. thanks.

@gbrmachado Before creating a PR, I should know those mentioned above first so You can create it.

@shigeki
Copy link
Contributor Author

shigeki commented Jan 17, 2017

This issue was resolved in a0e13da. Thanks! @watilde

@shigeki shigeki closed this as completed Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants