crypto: assign and use ERR_CRYPTO_UNKNOWN_CIPHER #31437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Jan 21, 2020
devnexen
approved these changes
Jan 21, 2020
sam-github
approved these changes
Jan 21, 2020
cjihrig
approved these changes
Jan 21, 2020
Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
tniessen
added
the
author ready
Trott
approved these changes
Jan 23, 2020
jasnell
approved these changes
Jan 23, 2020
|
Landed in 8c313ce |
Trott
pushed a commit
that referenced
this pull request
Jan 23, 2020
PR-URL: #31437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
@codebytere is this still blocked for v12.x? |
|
I don't know. I am still not sure if this is considered a breaking change or not (I didn't assume so, but IIRC @jasnell did). Ref: #31873 (comment) |
|
Per policy assigning new Error codes is semver-major typically because they also come with a change to the error message. After that initial assignment, changing the message is patch or minor. Not dead set on that policy now that error codes have become a natural normal thing. |
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#31437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #31437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
Errors with the message'Unknown cipher'with new errors with the same message, but assigns a new codeERR_CRYPTO_UNKNOWN_CIPHER. This should not break existing applications since it only adds the.codeproperty, and should therefore not be semver-major.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes