src: use As() instead of Cast() for conversions
#40287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
RaisinTen
force-pushed
the
src/use-As-instead-of-Cast-for-conversions
branch
from
9bb6b65 to
1967e1c
Compare
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
author ready
tniessen
approved these changes
Oct 2, 2021
lpinca
reviewed
Oct 2, 2021
22 tasks
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src/use-As-instead-of-Cast-for-conversions
branch
from
1967e1c to
fcb40c7
Compare
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Oct 3, 2021
targos
approved these changes
Oct 3, 2021
jasnell
approved these changes
Oct 3, 2021
22 tasks
Flarna
approved these changes
Oct 4, 2021
21 tasks
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 8fc4169...7b8552f |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This was referenced Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mostly use
As()instead ofCast()in our code, so this changereplaces the remaining calls to
Cast()with calls toAs()to maintainthe consistency.
Refs: https://github.com/nodejs/node/pull/39921/files#r702293529
Signed-off-by: Darshan Sen darshan.sen@postman.com