Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Code owner in Pull Request for translations #2280

Closed
TiagoDanin opened this issue Jun 21, 2019 · 2 comments
Closed

Use Code owner in Pull Request for translations #2280

TiagoDanin opened this issue Jun 21, 2019 · 2 comments

Comments

@TiagoDanin
Copy link

Suggestion

Use Code owner in Pull Request for translations and enabled Require review from Code Owners.

Reason

Improves translation feedback.
This will be of great help to nodejs/nodejs-pt#80 (comment).

Example (Code Owner File)

# Locale - Team
locale/pt-br/* @nodejs/nodejs-pt
locale/fr/* @nodejs/nodejs-fr
# ... #
@AbdoliMR
Copy link

AbdoliMR commented Nov 6, 2019

@TiagoDanin I can do it.

@okuryu
Copy link
Contributor

okuryu commented Nov 6, 2019

#2710 will probably resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@okuryu @TiagoDanin @AbdoliMR