Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker example to use most recent LTS #2983

Merged
merged 10 commits into from
Apr 2, 2020

Conversation

jamesmacfie
Copy link
Contributor

@jamesmacfie jamesmacfie commented Feb 25, 2020

Update Docker example to use most recent LTS version.

@jamesmacfie
Copy link
Contributor Author

Looks like I missed a bunch of places where this is done, but this change may be moot given I just read through #2953

@XhmikosR
Copy link
Contributor

Yeah, let's close this since the changes are being discussed in #2953.

@XhmikosR XhmikosR closed this Feb 25, 2020
@XhmikosR
Copy link
Contributor

Scratch that, let's reopen this, this is a much smaller change and it might be easier to land than the other one.

@XhmikosR XhmikosR reopened this Feb 25, 2020
@XhmikosR XhmikosR requested a review from Trott February 25, 2020 07:23
@mkrawczuk
Copy link

I'd hold with merging it yet. I really think it's silly to bump the version with every stable Node release, given that the tutorial explicitly states to use the latest Node version.

Or at least add to the Node LTS release procedure to bump the version number in the tutorial, which in my opinion also sounds a little silly.

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmacfie: Some notes:
1、There're some untranslated versions of LTS in the simplified Chinese, Japanese and Korean files, I've changed them together.
2、Add the comment for submitting.

ja-JP: Trans fixed
ko: Trans fixed
ja-JP: Trans fixed
rauno56 added a commit to rauno56/nodejs.org that referenced this pull request Oct 26, 2021
Update node LTS version for the guide for docerizing node applications.

Related: nodejs#2983, nodejs#2953
DerekNonGeneric pushed a commit that referenced this pull request Oct 26, 2021
Update node LTS version for the guide for docerizing node applications.

Related: #2983, #2953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants