Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to fetch the file offset of the embedded data #2

Closed
RaisinTen opened this issue Jul 15, 2022 · 1 comment
Closed

Provide a way to fetch the file offset of the embedded data #2

RaisinTen opened this issue Jul 15, 2022 · 1 comment

Comments

@RaisinTen
Copy link
Contributor

Problem

The current mechanism returns a pointer to the embedded data and its size. Passing it into V8 forces us to load the entire embedded data into a buffer in memory. It is not efficient to prematurely store the entire payload in memory, especially if the payload is huge.

See nodejs/node#42334 (comment).

Suggested solution

If the Postject Api returns the file offset of the embedded data, we will be able to parse only the parts that we are interested in.

@RaisinTen
Copy link
Contributor Author

This is not needed anymore, see nodejs/node#42334 (comment)

@RaisinTen RaisinTen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant