Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

TODO: Test QuicStream #291

Open
16 tasks
jasnell opened this issue Jan 21, 2020 · 2 comments
Open
16 tasks

TODO: Test QuicStream #291

jasnell opened this issue Jan 21, 2020 · 2 comments

Comments

@jasnell
Copy link
Member

jasnell commented Jan 21, 2020

JavaScript Side:

  • Verify opening a stream (all options, failure and success conditions)
  • Verify stream ID, origin, and direction indictions
  • Verify client side stream minimally usable before connection is ready (ability to buffer writees). Verify that functions unavailable before connection is ready fail appropriately.
  • Verify proper emission of QuicStream events
  • Verify write and end callbacks are called appropriately
  • Verify state fields (e.g. pending, aborted, destroyed, etc) are reporting as expected
  • Verify QuicStream statistics and histograms
  • Verify appropriate and consistent destroy flow
  • Verify sendFile/sendFD working appropriately
  • Verify write working appropriately
  • Verify sending informational, initial, and trailing headers (HTTP/3 only)
  • Verify push streams (HTTP/3 only)

C++ Side

  • Verify QuicBuffer-based data buffering and callbacks
  • Verify QuicBuffer-based data flow to QUIC
  • Verify inbound data flow
  • Verify Stream Reset and Stream Close appropriately handled
@addaleax
Copy link
Member

@jasnell For items like

Verify sendFile/sendFD working appropriately

Are those things that can already be crossed off, given that there are tests for this?

@jasnell
Copy link
Member Author

jasnell commented Jan 21, 2020

Yes, this is really an audit list. We need to go through the existing tests to make sure they provide proper coverage, but if they do, feel free to check off

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants