-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.5.0: global is not defined #529
Comments
I could only track those two places. |
There is another occurence in Lines 5 to 6 in 700d28b
|
Thanks for the quick fix and maintaining this package ❤️ I can confirm that my problem is fixed now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just upgraded to readable-stream@4.5.0 and I am now getting this error (using readable-stream in the browser):
global is not defined
I tracked these changes back to this commit, where there are many references to
global
that did not exist before. I'm wondering if they should be changed toglobalThis
instead, so it will not crash in browsers (global
is only globally defined in node).Here is one of the affected places for quick reference:
readable-stream/lib/ours/util.js
Lines 5 to 6 in 700d28b
The text was updated successfully, but these errors were encountered: