Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test to cover all documents the nodejs/node lints #31

Closed
nschonni opened this issue Oct 14, 2019 · 1 comment
Closed

Expand test to cover all documents the nodejs/node lints #31

nschonni opened this issue Oct 14, 2019 · 1 comment

Comments

@nschonni
Copy link
Member

Currently the CI test only covers the docs, but there are a few additional directories that the main repo checks https://github.com/nodejs/node/blob/5f80df882057522c38c30b99f4bf25d82c68f662/Makefile#L1196-L1200
The current remark-lint way of ignoring globs might not work, so a test script or some && calls might be required
@XhmikosR
Copy link
Contributor

Just please remember Windows too. I personally use shx in npm scripts for cross-platform commands.

If you make a PR feel free to ping me.

nschonni referenced this issue in nschonni/remark-preset-lint-node Oct 15, 2019
@nschonni
chore: Expand CI test globs
1f634a2 
Releated to #31
Doesn't include tools/doc or test
@nschonni nschonni mentioned this issue Oct 15, 2019
Merged
nschonni referenced this issue in nschonni/remark-preset-lint-node Oct 15, 2019
@nschonni
chore: Expand CI test globs
764980f 
Releated to #31
Doesn't include tools/doc or test
nschonni referenced this issue in nschonni/remark-preset-lint-node Oct 15, 2019
@nschonni
chore: Expand CI test globs
50b104a 
Fixes #31
nschonni referenced this issue in nschonni/remark-preset-lint-node Oct 15, 2019
@nschonni
chore: Expand CI test globs
0982091 
Fixes #31
@Trott Trott closed this as completed in 7e357aa Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @nschonni