Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici crashes on node compiled without crypto #1612

Closed
aduh95 opened this issue Aug 21, 2022 · 2 comments · Fixed by #1613
Closed

Undici crashes on node compiled without crypto #1612

aduh95 opened this issue Aug 21, 2022 · 2 comments · Fixed by #1613
Assignees

Comments

@aduh95
Copy link
Contributor

aduh95 commented Aug 21, 2022

@nodejs/undici this seems to break with a container/machine without OpenSSL:
https://ci.nodejs.org/job/node-test-commit-linux-containered/33340/nodes=ubuntu1804_sharedlibs_withoutssl_x64/

17:44:45     [UNEXPECTED_FAILURE][FAIL] Importing an i32 global with an incorrectly-typed value: ""
17:44:45     Node.js is not compiled with OpenSSL crypto support
17:44:45     Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support

Originally posted by @MoLow in nodejs/node#44319 (comment)

@aduh95 aduh95 changed the title Undici doesn't work on node compiled without crypto Undici crashes on node compiled without crypto Aug 21, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 21, 2022

It looks like the crash was introduced in #1596.

const { createHash } = require('crypto')

@KhafraDev KhafraDev self-assigned this Aug 21, 2022
@KhafraDev
Copy link
Member

I'm going to work on this (and a few other issues I had with #1596)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants